feedback

Coordinator
Apr 1, 2008 at 7:48 AM
Pls give me any feedback
Developer
Jul 10, 2010 at 7:16 PM
Edited Jul 10, 2010 at 7:33 PM

Hi lacc,

Actually thank you about this program. It helped me great. I have some suggestions.

1- NEW FEATURE: a GUI will definately multiply the popularity

2- NEW FEATURE: SP Name  formats could be parametric.  you may consider simply modifying the following line: string procedureName = spprefix + "Update" + tableName +spsuffix;

3- BUG: NVARCHAR(MAX) fields are not correctly defined. it returns -1 as length. (Line number 418 in MSSQL_GenerateStoredProceduresClass.cs)

4- NEW FEATURE: Instead of generating an sql file for each sp, i recommend putting everything inside one file. At least it could be optional.

5- BUG??: No need to generate Insert or Update for views. Just modify your selecttablesquery in Queryhelper.cs

SELECT t.TABLE_NAME, COLUMN_NAME, DATA_TYPE, CHARACTER_MAXIMUM_LENGTH from INFORMATION_SCHEMA.COLUMNS c
LEFT JOIN INFORMATION_SCHEMA.TABLES t ON t.TABLE_NAME=c.TABLE_NAME
WHERE
t.TABLE_TYPE<>'VIEW'
order by t.TABLE_NAME

6- NEW FEATURE: Table fields could be optional to insert or update (NULL, NOT NULL). So does the Stred procs can handle optional parameters. It could be choice for the user whether to generate full insert or necessary insert.  

I modified your code a little bit and tailored for my own needs such as stored proc naming.

I really appreciated your efforts and thank you again.

Best Regards

Onur 

 

Feb 9, 2011 at 3:33 PM

Once I have gone through   stored procedure generator tools4sql . It has some nice features so it is better to have one look at it.